HMS-2694 fix: exclude disabled domains from host-conf #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
reviewed
Oct 11, 2023
A domain with `auto_enrollment_enabled = FALSE` should not be returned in a host-conf response. Iterate the returned records (no longer limited to 2) and exclude disabled domains. Also improve the HTTP response status for some expected ways host-conf can fail. - No matching domains (500 -> 404) - Multiple matching domains (500 -> 409) Also remove a seemingly obsolete comment.
frasertweedale
force-pushed
the
hostconf-exclude-disabled-domains
branch
from
4f28d6d to
cf59f88
Compare
tiran
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A domain with
auto_enrollment_enabled = FALSEshould not bereturned in a host-conf response. Iterate the returned records (no
longer limited to 2) and exclude disabled domains.
Also improve the HTTP response status for some expected ways
host-conf can fail.
Also remove a seemingly obsolete comment.