refactor(HMS-4895): use -oci-ta wherever possible #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avisiedo
force-pushed
the
hms-4895-oci-ta
branch
8 times, most recently
from
0ffefd3 to
677878f
Compare
|
Maybe rebase to see if the Konflux error goes away? |
|
The commit messages refers to |
|
It would be helpful to reference https://konflux-ci.dev/architecture/ADR/0036-trusted-artifacts.html in the commit message, and perhaps also in a comment in the tekton .yaml file. |
avisiedo
force-pushed
the
hms-4895-oci-ta
branch
3 times, most recently
from
2988713 to
44a7971
Compare
|
@avisiedo please rebase on latest |
Copy LICENSE to /licenses/LICENSE to accomplish EC. Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-4895-oci-ta
branch
2 times, most recently
from
a238406 to
5cd610f
Compare
|
/retest |
Prepare the change for adding the unit test task, by migrating the tasks to -oci-ta which does not require PVC and the ephemeral information is trusted. This change apply to the pullrequest tekton pipeline. https://konflux-ci.dev/architecture/ADR/0036-trusted-artifacts.html Refactor using as guideline the source at: https://github.com/konflux-ci/bazel-builder/blob/main/.tekton/bazel5-ubi8-pull-request.yaml https://issues.redhat.com/browse/HMS-4556 Signed-off-by: Alejandro Visiedo <[email protected]>
Using trusted artifacts for the push tekton pipeline. https://konflux-ci.dev/architecture/ADR/0036-trusted-artifacts.html Refactor using as guideline the source at: https://github.com/konflux-ci/bazel-builder/blob/main/.tekton/bazel5-ubi8-push.yaml https://issues.redhat.com/browse/HMS-4895 Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-4895-oci-ta
branch
from
5e64146 to
6a90038
Compare
1 task
frasertweedale
approved these changes
Dec 12, 2024
avisiedo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the change for adding the unit test task, by migrating the tasks to -oci-ta which does not require PVC and the ephemeral information is trusted.
This change apply to the pullrequest tekton pipeline.
https://issues.redhat.com/browse/HMS-4556
TODO