Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Limit Bug #81

Open
tdgroot opened this issue Mar 20, 2015 · 1 comment
Open

Rate Limit Bug #81

tdgroot opened this issue Mar 20, 2015 · 1 comment
Labels
enhancement

Comments

@tdgroot
Copy link

tdgroot commented Mar 20, 2015

When requesting the Rate Limit / Rate Limit Remaining, when no request has been done yet, the library will crash. There needs to be done some checking if the rate limit is set.
hphuhtin added a commit to Communauts/podio-php that referenced this issue Nov 28, 2015
@hphuhtin
Issue podio-community#81 return only an existing rate-limit
e073779 
Check that API rate limit information exists before trying to return it (ie. a reply has been received from the API from a request).
@hphuhtin hphuhtin mentioned this issue Nov 28, 2015
Merged
daniel-sc added a commit to daniel-sc/podio-php that referenced this issue Jan 29, 2016
@daniel-sc
correcting reference to $last_response
3fbe23b 
fixing podio-community#81
daniel-sc added a commit to daniel-sc/podio-php that referenced this issue Jan 29, 2016
@daniel-sc
correcting reference to $last_response + rate_limit header
d53547e 
fixing podio-community#81
@rmckeel
Copy link

rmckeel commented Jun 30, 2016

Would love to see these fixes from @daniel-sc merged back into master!

daniel-sc added a commit that referenced this issue Nov 3, 2019
@daniel-sc
correcting reference to $last_response + rate_limit header
b951c33 
fixing #81
@daniel-sc daniel-sc mentioned this issue Nov 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daviferreira @tdgroot @rmckeel