Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for permission scopes in authorize_url. Fix ratelimit response if no request made. #108

Merged
merged 2 commits into from
Dec 18, 2015

Conversation

hphuhtin
Copy link
Contributor

Check that API rate limit information exists before trying to return it (ie. a reply has been received from the API from a request). This is from Rate Limit Bug #81

Check that API rate limit information exists before trying to return it (ie. a reply has been received from the API from a request).
The authorize_url($request_uri) didn't allow passing of the required permission scope.
If unset, the Podio API defaults to global:all so behaviour does not change to calls without the scope.
@hphuhtin hphuhtin changed the title Issue #81 return only an existing rate-limit Support for permission scopes in authorize_url. Fix ratelimit response if no request made. Dec 3, 2015
@hphuhtin
Copy link
Contributor Author

Any comments? Any reason why these can't be committed? It has been 3 weeks now :)

daviferreira added a commit that referenced this pull request Dec 18, 2015
Support for permission scopes in authorize_url. Fix ratelimit response if no request made.
@daviferreira daviferreira merged commit 20034e3 into podio-community:master Dec 18, 2015
@daviferreira
Copy link
Contributor

Sorry, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants