Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create campaign application - fixes #2002

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create campaign application - fixes #2002

wants to merge 2 commits into from

Conversation

gparlakov
Copy link
Contributor

@gparlakov gparlakov commented Jan 18, 2025 •
edited
Loading

  • move the field cause (aka goal - "за какво са нужни средствата") down as per request from team campaigns
  • add a "at least one document" hint to the document
  • make the beneficiary relationship required (as it is on the API side)
  • add validation error for not accepted terms
  • add validation for missing document
  • reset touched state after first step b/c that first step's submit makes all fields on steps 2 and 3 touched and shows errors immediately

image

image

@gparlakov gparlakov force-pushed the create-campaign-application-fixes branch from 634dc15 to 50b7ea7 Compare January 18, 2025 16:52
@gparlakov
feat: campaign application fixes
c129902 
- move the field cause (aka goal - "за какво са нужни средствата") down as per request from team campaigns
- add a "at least one document" hint to the document
- make the beneficiary relationship required (as it is on the API side)
- add validation error for not accepted terms
- add validation for missing document
- reset touched state after first step b/c that first step's submit makes all fields on steps 2 and 3 touched and shows errors immediately
@gparlakov gparlakov force-pushed the create-campaign-application-fixes branch from 50b7ea7 to c129902 Compare January 18, 2025 16:54
@gparlakov gparlakov added the run tests Allows running the tests workflows for forked repos label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run tests Allows running the tests workflows for forked repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gparlakov