Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): enable fail fast strategy #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axel7083
Copy link
Contributor

Description

This may help reducing the number of jobs running on the organisation

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested a review from a team as a code owner February 28, 2025 08:23
@axel7083 axel7083 requested review from dgolovin, cdrage, SoniaSandler and benoitf and removed request for a team February 28, 2025 08:23
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that during a call, there were a request from maintainers to know all the failures and not the first one b/c at some point it was fail fast

(for example: did I just forget the linter or it's the linter and unit tests and also e2e)

@axel7083
Copy link
Contributor Author

(for example: did I just forget the linter or it's the linter and unit tests and also e2e)

I understand the remark, but this is a comfort that is costly 🤔 chaining and fast failing reduce a bit the consumption when the developer commit something that has an issue.

image

This model could be chaining further, putting the linting as a condition for all other checks. More in depth analsys finding out which check is failing the most would be interesting to properly organise the CI to reduce usage.

For example, I would not be surprised to only start e2e if unit tests are passing, e2e are very costly and long task, meaning they probably should only run to ensure no regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants