Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues building for Library Evolution, Xcode 16 #234

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gemmakbarlow
Copy link

@gemmakbarlow gemmakbarlow commented Sep 29, 2024

  • Fixes some issues building for Library Evolution, Xcode 16
  • Adds Makefile targets used to create the error state prior to fixing them
  • Adjusts CI to incorporate both Xcode 15 and 16
  • Adds Makefile target build-for-library-evolution to CI

@gemmakbarlow
Copy link
Author

@stephencelis - this should be the last in the series from me 😄

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
[email protected] Outdated Show resolved Hide resolved
@gemmakbarlow
Copy link
Author

I also took a stab at updating CI to address the error from the previous run (not finding the 17.5 simulator with Xcode 16 selected IIRC). Let me know what you think; a couple of ways to do this.

Makefile Outdated Show resolved Hide resolved
@gemmakbarlow
Copy link
Author

Noting that this is working for me locally @stephencelis - might be worth a re-run.

@gemmakbarlow
Copy link
Author

@stephencelis - what do you think about giving this one a re-rerun, given it's working for me locally ? (I don't have that button available in the UI).

@stephencelis
Copy link
Member

@gemmakbarlow I've been re-running but sadly GitHub actions just seem to be flakey. Here's hoping for a green run this time!

@stephencelis
Copy link
Member

@gemmakbarlow Sorry for the churn. I'm frustrated with CI and I think some of the changes I've made to your PR have made things worse in how the simulator is getting resolved. I'm not sure if you want to take another stab at fixing things, or if you want me to try again when I have time.

@gemmakbarlow
Copy link
Author

All good - I can take a stab at fixing it, hopefully later tonight.

@gemmakbarlow gemmakbarlow force-pushed the gemmakbarlow/xcode-16-library-evolution branch from 0398acd to 6655437 Compare November 1, 2024 13:58
@gemmakbarlow gemmakbarlow force-pushed the gemmakbarlow/xcode-16-library-evolution branch from 6655437 to eb13416 Compare January 8, 2025 14:36
@gemmakbarlow
Copy link
Author

All good - I can take a stab at fixing it, hopefully later tonight.

Reader, she did not get back to it later tonight - but she is hoping to spend some time on this today / tomorrow.

@gemmakbarlow gemmakbarlow force-pushed the gemmakbarlow/xcode-16-library-evolution branch 4 times, most recently from 82a4dc1 to da539ff Compare January 15, 2025 14:17
steps:
- run: echo "Preparing Environment Variables..."
outputs:
XCODE_15_VERSION: 15.4
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A workaround, as environment variables are not usable within a matrix, annoyingly.

@gemmakbarlow
Copy link
Author

gemmakbarlow commented Jan 15, 2025

All good - I can take a stab at fixing it, hopefully later tonight.

Reader, she did not get back to it later tonight - but she is hoping to spend some time on this today / tomorrow.

@stephencelis - thrilled to report I finally got back to this, and things are working. Splitting out the library evolution builds into a separate job allowed for them to be run against a more appropriate matrix, and seems to have solved the iOS version / Xcode version issues we were seeing previously.

Further feedback welcomed.

@gemmakbarlow
Copy link
Author

image

@gemmakbarlow
Copy link
Author

Friendly bump on this one when you get a minute @stephencelis

@gemmakbarlow gemmakbarlow force-pushed the gemmakbarlow/xcode-16-library-evolution branch from 0fe3ec3 to 1c434e3 Compare January 29, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants