Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codec] Re-enable map into protobufs after the addition of autocli support #1086

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Feb 20, 2025

Summary

Re-enable supplier activation test and clean up TODO comments related to protobuf maps

Primary Changes:

  • Re-enabled User can restake a Supplier waiting for it to become active again test in stake_supplier.feature
  • Removed all TODO_MAINNET comments and related code that was temporarily disabling protobuf map functionality

Secondary changes:

  • Updated CometBFT config version from 0.38.10 to 0.38.12
  • Changed TODO comment in service.proto from TODO_TECHDEBT(#1033) to TODO_POST_MAINNET
  • Updated golang/mock dependency to be a direct import rather than indirect

Issue

Type of change

Select one or more from the following:

Sanity Checklist

  • I have updated the GitHub Issue assignees, reviewers, labels, project, iteration and milestone
  • For docs, I have run make docusaurus_start
  • For code, I have run make go_develop_and_test and make test_e2e
  • For code, I have added the devnet-test-e2e label to run E2E tests in CI
  • For configurations, I have update the documentation
  • I added TODOs where applicable

@Olshansk Olshansk added bug Something isn't working on-chain On-chain business logic devnet-test-e2e labels Feb 20, 2025
@Olshansk Olshansk requested review from red-0ne and okdas February 20, 2025 21:30
@Olshansk Olshansk self-assigned this Feb 20, 2025
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1086)
Grafana network dashboard for devnet-issue-1086

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Feb 20, 2025
@Olshansk Olshansk added this to the MainNet Launch milestone Feb 20, 2025
@Olshansk Olshansk marked this pull request as ready for review February 20, 2025 21:39
@Olshansk Olshansk changed the title [Codec] Fixing 1033 issues [Codec] Re-enable map into protobufs after the addition of autocli support Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devnet devnet-test-e2e on-chain On-chain business logic push-image CI related - pushes images to ghcr.io
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant