fix: avoid endless loop when SCardEstablishContext is not successful #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe drop the sleep and the whole do-while (as the comments say) and have it fail fast instead? |
|
@martinpaljak You are probably right; i thought about that as the while loop might be there to ensure if enabling the service takes a bit time (the win32 code before). But I do think it is the better solution to let the caller handle that case instead |
|
Just for information: we published and tested this code internally and got rid of all the hangs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered that on systems that have never connected any smart card readers, the application runs on 100%; the reason is the while loop around the SCardEstablishContext