Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure report rustc version if pre-built binary will be used #1234

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Sep 16, 2024

R CMD check now checks to see if the rustc version is shown in the installation log, so even if rustc is not used, the version must be shown.
r-devel/r-svn@6114d41

I saw this warning at https://github.com/eitsupi/r-glaredb/actions/runs/10879498825/job/30184319369

 ❯ checking Rust compilation ... WARNING
    No rustc version reported prior to compilation

In addition, remove the unnecessary flag added by #1212.

@etiennebacher
Copy link
Collaborator

Thanks

@etiennebacher etiennebacher merged commit fa98ad7 into main Sep 17, 2024
16 of 18 checks passed
@etiennebacher etiennebacher deleted the fix-configure branch September 17, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants