Skip to content

fix:[动态配置]修复config_flow递归加读锁导致的死锁问题 #286

fix:[动态配置]修复config_flow递归加读锁导致的死锁问题

fix:[动态配置]修复config_flow递归加读锁导致的死锁问题 #286

Re-run triggered August 10, 2024 13:13
Status Success
Total duration 1m 35s
Artifacts

revive.yml

on: pull_request
Matrix: Run Revive Action
Fit to window
Zoom out
Zoom in

Annotations

66 warnings
Run Revive Action (1.17.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.17.x): examples/activehealthcheck/main.go#L18
should have a package comment
Run Revive Action (1.17.x): plugin/location/remotehttp/remotehttp.go#L18
should have a package comment
Run Revive Action (1.17.x): benchmark/benchmain/main.go#L18
should have a package comment
Run Revive Action (1.17.x): plugin/location/local/local.go#L18
should have a package comment
Run Revive Action (1.17.x): plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.17.x): api_config.go#L116
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.17.x): benchmark/benchsimple/main.go#L18
should have a package comment
Run Revive Action (1.17.x): api.go#L134
exported type GetConfigFileRequest should have comment or be unexported
Run Revive Action (1.16.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.16.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.16.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.16.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.16.x): plugin/loadbalancer/common/half_open.go#L18
should have a package comment
Run Revive Action (1.16.x): plugin/loadbalancer/hash/config.go#L18
should have a package comment
Run Revive Action (1.16.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.16.x): plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.16.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.16.x): plugin/location/local/local.go#L18
should have a package comment
Run Revive Action (1.15.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.15.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.15.x): pkg/model/pb/metric/code.go#L28
exported const ExecuteSuccess should have comment (or a comment on this block) or be unexported
Run Revive Action (1.15.x): pkg/plugin/configfilter/configfilter.go#L19
should have a package comment
Run Revive Action (1.15.x): pkg/model/pb/metric/code.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.15.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.15.x): api.go#L134
exported type GetConfigFileRequest should have comment or be unexported
Run Revive Action (1.15.x): api.go#L162
exported type CircuitBreakerAPI should have comment or be unexported
Run Revive Action (1.15.x): pkg/plugin/location/location.go#L27
exported const ProviderName should have comment (or a comment on this block) or be unexported
Run Revive Action (1.15.x): pkg/plugin/loadbalancer/util.go#L25
parameter 'ctx' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.18.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.18.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.18.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.18.x): api.go#L134
exported type GetConfigFileRequest should have comment or be unexported
Run Revive Action (1.18.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment
Run Revive Action (1.18.x): api_config.go#L116
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.18.x): api.go#L162
exported type CircuitBreakerAPI should have comment or be unexported
Run Revive Action (1.18.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.18.x): api_config.go#L138
comment on exported function NewConfigGroupAPIByContext should be of the form "NewConfigGroupAPIByContext ..."
Run Revive Action (1.18.x): api_config.go#L127
comment on exported function NewConfigGroupAPIByFile should be of the form "NewConfigGroupAPIByFile ..."
Run Revive Action (1.18.x): plugin/weightadjuster/ratedelay/ratedelay.go#L58
parameter 'service' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.20.x): plugin/loadbalancer/weightedrandom/wr.go#L18
should have a package comment
Run Revive Action (1.20.x): plugin/loadbalancer/weightedrandom/wr.go#L65
parameter 'ignoreHalfOpen' seems to be unused, consider removing or renaming it as _
Run Revive Action (1.20.x): api.go#L134
exported type GetConfigFileRequest should have comment or be unexported
Run Revive Action (1.20.x): api_config.go#L116
comment on exported function NewConfigGroupAPIByConfig should be of the form "NewConfigGroupAPIByConfig ..."
Run Revive Action (1.20.x): api_config.go#L138
comment on exported function NewConfigGroupAPIByContext should be of the form "NewConfigGroupAPIByContext ..."
Run Revive Action (1.20.x): api_config.go#L127
comment on exported function NewConfigGroupAPIByFile should be of the form "NewConfigGroupAPIByFile ..."
Run Revive Action (1.20.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.20.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.20.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.20.x): pkg/plugin/register/plugins.go#L18
should have a package comment
Run Revive Action (1.19.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Revive Action (1.19.x): api/config.go#L41
a blank import should be only in a main or test package, or have a comment justifying it
Run Revive Action (1.19.x): examples/mock/main.go#L69
invalid file examples/mock/main.go: examples/mock/main.go:69:13: expected ';', found 0 (and 1 more errors)
Run Revive Action (1.19.x): pkg/plugin/location/proxy.go#L26
exported type Proxy should have comment or be unexported
Run Revive Action (1.19.x): pkg/plugin/location/location.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/location/location.go#L27
exported const ProviderName should have comment (or a comment on this block) or be unexported
Run Revive Action (1.19.x): pkg/plugin/metrics/proxy.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/register/plugins.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/register/plugins.go#L21
a blank import should be only in a main or test package, or have a comment justifying it
Run Revive Action (1.19.x): plugin/loadbalancer/common/half_open.go#L18
should have a package comment
Run Revive Action (1.19.x): pkg/plugin/weightadjuster/proxy.go#L18
should have a package comment