Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials: Update parachain tutorial #234

Merged
merged 12 commits into from
Dec 13, 2024
Merged

Tutorials: Update parachain tutorial #234

merged 12 commits into from
Dec 13, 2024

Conversation

CrackTheCode016
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 commented Dec 10, 2024

Content Changes

This PR aims to better illustrate the process of deploying on Paseo and to use some of the 'cutting' edge tools which should be available soon (tm), such as:

  • polkadot-omni-node
  • chain-spec-builder

This PR also fills in some missing blanks throughout the Paseo deployment process.

IA Changes

This PR adds a new section to the IA called "Deploy on Relay Chain", wherein should contain tutorials relating to deploying on various networks.

Closes #176

@CrackTheCode016 CrackTheCode016 requested a review from a team as a code owner December 10, 2024 02:01
@CrackTheCode016 CrackTheCode016 marked this pull request as draft December 10, 2024 02:01
@CrackTheCode016 CrackTheCode016 marked this pull request as ready for review December 10, 2024 21:54
@CrackTheCode016
Copy link
Collaborator Author

Note that the IA may change in the future, but this should be fine for now.

@kianenigma
Copy link
Contributor

requested review from some omni-node devs within Parity.

@CrackTheCode016
Copy link
Collaborator Author

@kianenigma FYI - The versions of polkadot-omni-node and chain-spec-builder used are off of the master branch (installed from git via cargo install). I assume these will be deployed with the next major release?

@iulianbarbu
Copy link
Contributor

@kianenigma FYI - The versions of polkadot-omni-node and chain-spec-builder used are off of the master branch (installed from git via cargo install). I assume these will be deployed with the next major release?

The binaries should be downloadable from the release candidate artifacts here: https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2412-rc2, but they will also be part of the next major polkadot-sdk release page, on github.

However the latest crates versions can not be found anywhere yet, even with the release candidate. They should be published with the next major release.

Copy link

@skunert skunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good to me 👍

@iulianbarbu
Copy link
Contributor

Also, I think this PR closes: #176. Maybe worth adding it in the PR description.

@CrackTheCode016
Copy link
Collaborator Author

@0xLucca @nhussein11 This PR can probably be merged now, but we should test some of the local tutorials to make sure they are in working order with these new binaries before they are merged. I can address this tomorrow and make a new PR to ensure they are working if needed. WDYT?

@CrackTheCode016
Copy link
Collaborator Author

Also, it might be nice to have a page somewhere to explain the role of these different binaries, and links to where you can install them. Maybe even at the beginning of tutorials, would love to hear feedback on this

Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!👍 I haven't rendered the docs to check how they look like, and follow precisely along the tutorial, but I can take a look tomorrow more closely. Thanks!

./target/release/parachain-template-node build-spec \
--disable-default-bootnode > plain-parachain-chainspec.json
chain-spec-builder create --relay-chain paseo \
--para-id 4508 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a placeholder instead of 4508 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only reason it's that specific ID is because earlier the para id reserved is 4508

./target/release/parachain-template-node build-spec \
--disable-default-bootnode > plain-parachain-chainspec.json
chain-spec-builder create --relay-chain paseo \
--para-id 4508 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@kianenigma
Copy link
Contributor

Note that the matter of specifying the parachain ID in the template is a bit shitty now, but Shawn improved it lately here:

https://github.com/paritytech/polkadot-sdk/pull/6744/files

One of the areas is a hardcoded para id in the node.

one is the genesis config

one in the runtime

@kianenigma
Copy link
Contributor

This PR adds a new section to the IA called "Deploy on Relay Chain", wherein should contain tutorials relating to deploying on various networks.

Can you please make an issue to address later that you can basically skip setting up a local relay by using --experimental-rpc-endpoint?

Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xLucca 0xLucca merged commit 37ee5fe into master Dec 13, 2024
1 check passed
@0xLucca 0xLucca deleted the bd-parachain-tutorial branch December 13, 2024 14:26
nhussein11 added a commit that referenced this pull request Dec 19, 2024
* updates so far

* Add finishing touches

* comments

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* change to chain-spec-builder

* Update tutorials/polkadot-sdk/parachains/deploy-to-relay-chain/deploy-on-paseo.md

Co-authored-by: Iulian Barbu <[email protected]>

* feedback

* replace parachain-template-node

* fix most instructions

* few things

---------

Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Iulian Barbu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update parachain-template tutorials to use polkadot-omni-node
6 participants