force unstake the last remaining corrupt ledger #538
+36
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be just its own referendum? |
yeah it could, but since it would require Root, and we have previously done other fixes related to this bug as runtime upgrade, I opted for this. We can still do Root, but it will certainly be longer, and a more cumbersome process. |
|
This could also be done via the whitelisted track? I mean this is just fixing up stuff, nothing controversial. |
|
Yeah since it is a technical bug, fellowship can be asked to whitelist. I think there is an easier path if we merge this as-is, since we are close to publishing 1.4 anyways, but if you think otherwise, we can also pursue it via the fellowship. |
bkchr
approved these changes
Jan 10, 2025
| impl OnRuntimeUpgrade for Migrate { | ||
| fn on_runtime_upgrade() -> frame_election_provider_support::Weight { | ||
| // ensure this only runs once, in the 1.4.0 release | ||
| if VERSION.spec_version == 1_400_000 { |
There was a problem hiding this comment.
Suggested change
| if VERSION.spec_version == 1_400_000 { | |
| if System::last_runtime_upgrade_spec_version() < 1_400_000 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last staking ledger that due to the bug found last year is in an inconsistent state.
The Support team is in touch with the owner, and force_staking them is the preferred way.
Note that this is only an action that we are doing because the root cause of the inconsistent stake was buggy code in the polkadot runtime, not any user interaction.
See: https://forum.polkadot.network/t/recover-corrupted-staking-ledgers-in-polkadot-and-kusama/9796