New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowbridge: Add support for Ether #548

Merged

fellowship-merge-bot merged 18 commits into polkadot-fellows:main from Snowfork:alistair/support-native-ether

Jan 31, 2025

Contributor

alistair-singh commented Jan 16, 2025 •

edited

Loading

Adds support for the bridging Ether.

TODO

Update snowbridge-router-primitives crate 2409-1 0.16.1
Add a test to test round trip of Ether.

alistair-singh mentioned this pull request

Release v1.4.0 #527

Open

6 tasks

Contributor

acatangiu commented Jan 23, 2025

Doesn't look good, new crates bring new minor or major versions of deps, doesn't build.

I see the snowfork crates have semver-minor bump, I expected patch bumps to have everything working ok.

alistair-singh force-pushed the alistair/support-native-ether branch 2 times, most recently from 61541b1 to d46f577 Compare

January 23, 2025 23:40

alistair-singh marked this pull request as ready for review

January 23, 2025 23:41

yrong reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

yrong reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

yrong reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

yrong approved these changes

View reviewed changes

Contributor

yrong left a comment

+1

github-actions bot requested a review from yrong

January 24, 2025 07:33

github-actions bot commented Jan 24, 2025

Review required! Latest push from author must always be reviewed

claravanstaden approved these changes

View reviewed changes

Contributor

claravanstaden left a comment

@alistair-singh adding ether does not require any runtime config, except the new snowbridge-router-primitives crate version, right?

Contributor Author

alistair-singh commented Jan 24, 2025

@alistair-singh adding ether does not require any runtime config, except the new snowbridge-router-primitives crate version, right?

No, we just need the new code in the crate which interprets 0x00... as Ether's multi-location. And the feature is blocked from the solidity side as it wont let you register and submit that address. Deploying the new version of the contract code will enable it by registering Ether at upgrade time.

yrong approved these changes

View reviewed changes

Contributor

yrong left a comment

+1

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Show resolved Hide resolved

bkontur reviewed

View reviewed changes

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/tests/snowbridge.rs Outdated Show resolved Hide resolved

github-actions bot requested review from claravanstaden and yrong

January 24, 2025 10:50

bkontur approved these changes

View reviewed changes

franciscoaguirre approved these changes

View reviewed changes

alistair-singh mentioned this pull request

Snowbridge: Register Ether Asset and Lower Bridge Fees #560

Open

acatangiu approved these changes

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

alistair-singh added 2 commits

January 29, 2025 10:54


          add test

885f55c


          fix compilation errors

84be967

alistair-singh and others added 15 commits

January 29, 2025 10:54


          Update changelog

4cca168


          updated snowbridge-router-primitives

44b186f


          update snowbridge crates

24976b2


          Revert "update snowbridge crates"

e54a2d6

This reverts commit 2ea7fd3.


          Use the correct version

389f7c8


          fix storage corruption bug

9e9416c


          fix tests

f319c71


          revert token amount

8b76a89


          make Ether Token Address explicit

5ecd33b


          fix up comments

c48e865


          all comment related changes

90b25a6


          factor test

e66a564


          fix test

2e17c4a


          Update CHANGELOG.md

8648fda

Co-authored-by: Adrian Catangiu <[email protected]>


          rebase from main

5da0c64

alistair-singh force-pushed the alistair/support-native-ether branch from e2f6f99 to 5da0c64 Compare

January 29, 2025 08:57

acatangiu approved these changes

View reviewed changes

eskimor approved these changes

View reviewed changes

Contributor

acatangiu commented Jan 30, 2025

/merge

fellowship-merge-bot bot enabled auto-merge (squash)

January 30, 2025 08:47

Contributor

fellowship-merge-bot bot commented Jan 30, 2025

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation


          Merge branch 'main' into alistair/support-native-ether

73491ef

claravanstaden approved these changes

View reviewed changes

acatangiu approved these changes

View reviewed changes

yrong approved these changes

View reviewed changes

Contributor

yrong left a comment

+1

fellowship-merge-bot bot merged commit 76d1fa6 into polkadot-fellows:main

50 of 51 checks passed

alistair-singh deleted the alistair/support-native-ether branch

January 31, 2025 08:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

acatangiu acatangiu approved these changes

bkontur bkontur approved these changes

franciscoaguirre franciscoaguirre approved these changes

yrong yrong approved these changes

claravanstaden claravanstaden approved these changes

eskimor eskimor approved these changes

Labels

None yet