-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up ExportGenesis #10
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
d8801bd
to
5d3b5d2
Compare
b5dc840
to
4d00138
Compare
A client can exist without connections hence relying on connections is not a fully valid approach
4d00138
to
cd382e8
Compare
As discussed, we will keep this PR open only as a temp commit that hardfork depends on. After client consensus state pruning is correctly implemented, we won't need this temp fix any more. |
Iterating over all client or consensus states is very expensive for a Polymer chain with a loopback client which makes state change on every block. It's safe to eliminate that client from the results.