-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of miniwallet server #7
Conversation
const ethers = require('ethers') | ||
const DEBUG = process.env.MINISERVER_DEBUG === 'true' || process.env.MINISERVER_DEBUG === '1' | ||
const APIDOCS = process.env.APIDOCS === 'true' || process.env.APIDOCS === '1' | ||
const config = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean this up to bare minimum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated @polymorpher can you review again and see what else (if anything) should be removed 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks on the right track - we need to handle errors better, make code more consistent with common styles and good practice, and reduce code duplications
…eedback from PR 7
This PR will include chain-code enhancements #3 and miniserver functionality #5