Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of miniwallet server #7

Closed
wants to merge 8 commits into from
Closed

Conversation

johnwhitton
Copy link
Collaborator

@johnwhitton johnwhitton commented Aug 22, 2022

This PR will include chain-code enhancements #3 and miniserver functionality #5

miniserver/app.js Outdated Show resolved Hide resolved
const ethers = require('ethers')
const DEBUG = process.env.MINISERVER_DEBUG === 'true' || process.env.MINISERVER_DEBUG === '1'
const APIDOCS = process.env.APIDOCS === 'true' || process.env.APIDOCS === '1'
const config = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean this up to bare minimum

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated @polymorpher can you review again and see what else (if anything) should be removed 🙏

miniserver/utils.js Outdated Show resolved Hide resolved
server/config.js Outdated Show resolved Hide resolved
Copy link
Owner

@polymorpher polymorpher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks on the right track - we need to handle errors better, make code more consistent with common styles and good practice, and reduce code duplications

@johnwhitton
Copy link
Collaborator Author

Closing this as being progressed under #8
After 8 is merged will review any outstanding items here and add them to #13

@johnwhitton johnwhitton closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants