Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to PostgreSQL and sqlx version upgrade #39

Merged
merged 32 commits into from
Aug 22, 2024
Merged

Conversation

bitfl0wer
Copy link
Member

@bitfl0wer bitfl0wer commented Aug 20, 2024

  • Upgrade sqlx from v0.7.4 to v0.8.0 (latest)
  • Migrate symfonia away from MySQL/MariaDB, over to PostgreSQL by popular demand

Running docker compose up --build with the given composefile and an existing, valid .env file starts the server up without error.

Todos from here:

  • Break out references to other objects into own tables instead of putting them as JSON

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@bitfl0wer bitfl0wer requested a review from Quat3rnion August 20, 2024 18:02
Copy link
Collaborator

@Quat3rnion Quat3rnion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks great, and the things I noted aren't explicitly necessary to merge either

@bitfl0wer bitfl0wer merged commit 292c1cd into main Aug 22, 2024
4 checks passed
@bitfl0wer bitfl0wer mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants