Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename polywrap client to client #78

Open
wants to merge 6 commits into
base: origin-dev
Choose a base branch
from
Open

refactor: rename polywrap client to client #78

wants to merge 6 commits into from

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Sep 12, 2023 •
edited
Loading

  • Changes:

    • Rename PolywrapClient -> Client
    • Rename PolywrapCoreClient -> BasicClient (can rename to something else)
    • Rename PolywrapClientConfigBuilder -> ClientConfigBuilder
    • Rename ClientConfigBuilder -> CoreClientConfigBuilder
    • Left CoreClient as it is

  • TODO:

    • client shouldn't build any wraps to avoid issues during breaking changes, use test-harness for that (separate PR)

dOrgJelli
dOrgJelli requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only NIT is the BasicClient change, I think it should still be CoreClient

packages/uri-resolvers/src/__tests__/wrapper-resolver/wrapper-resolver.spec.ts
@@ -1,6 +1,6 @@
import { Uri, UriResolutionContext } from "@polywrap/core-js";
import { expectHistory } from "../helpers/expectHistory";
import { PolywrapCoreClient } from "@polywrap/core-client-js";
import { BasicClient } from "@polywrap/basic-client-js";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this name change is necessary, I think we just want to stick with CoreClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli requested changes

@nerfZael nerfZael Awaiting requested review from nerfZael nerfZael is a code owner

@krisbitney krisbitney Awaiting requested review from krisbitney

@namesty namesty Awaiting requested review from namesty

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niraj-Kamdar @dOrgJelli