Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate decorator issue on tutorial code #68

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

khatchad
Copy link
Member

@khatchad khatchad commented Jan 3, 2024

A function with a decorator isn't being picked up in the CG.

@khatchad khatchad added the bug Something isn't working label Jan 3, 2024
@khatchad khatchad self-assigned this Jan 3, 2024
This time with the decorator.
@khatchad khatchad marked this pull request as ready for review January 3, 2024 16:08
@khatchad khatchad enabled auto-merge (squash) January 3, 2024 16:08
@khatchad khatchad merged commit d88e8f0 into master Jan 3, 2024
3 checks passed
@khatchad khatchad deleted the decorator_issue branch January 3, 2024 16:11
khatchad added a commit that referenced this pull request Jan 29, 2024
* Add tutorial test case.

* Add test case.

This time with the decorator.
@khatchad khatchad mentioned this pull request Jan 29, 2024
khatchad added a commit to wala/ML that referenced this pull request Jan 30, 2024
- Investigate decorator issue on tutorial code (ponder-lab#68)
- Fix comment.
- Add interprocedural dataset support (ponder-lab#69)
- Change log from warning to info.
- Add support for non-scalar datasets (ponder-lab#70)
- Use interprocedural analysis for property read case.
- Add logging.
- Fix non-scalar determination.
- Add logger.
- Fix logger.
- Add logging around callable workaround.
- Handle callables with lexical scoping.
- Formatting.
- Handle possible null receivers in callable lookup.
- Change log message.
- Add log.
- Add the ability to process datasets coming out of enumerate() (ponder-lab#71)
- Fix tests for input files with multiple functions.
- Enhance TF2 tests (ponder-lab#73)
- Separate tests by calling context (ponder-lab#74)
- Add tf.keras.layers.Dense.
- Move comment.
- Additional check.
- New API.
- Add autoencoder test.
- Move the value number check outside the context loop.
- More the sigmoid function to math.
- Format.
- Add API tf.add().
- Check the context/funciton PK mappings. (ponder-lab#77)
- Add URL.
- Add dataset generator and test.
- tf.nn.softmax isn't a tensor generator.
- Add URL.
- Apply spotless.
- Let's make the two tests only diff in the invocation.
- Prevent infinite recursion when processing instructions when finding tensor data flow sources.
- When we look for dataset tensor sources, we recurse up to the original defining instruction. However, there's a possibility that instructions have mutually recursive definitions due to the phi instruction. Let's prevent against that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant