Battery v4 #106
Merged
Battery v4 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 20, 2019 11:15
…nly one MainActivity
|
Sweet! I'll go ahead and merge this as well as give it a few runs... then get it up on the app store asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105, updates #76 .
This moves statusMode out of sharedPreferences, cleans up the loopers/creates a periodic bluetooth query, and cleans up notifications. Remaining % is now a progress bar. I have vibration working, and each notification is its own entity, so you can use Android notification settings to change the sound or other settings for a specific notification. For example, I opened the Android notification manager settings and set the 50% notification to use the Onewheel App's turnaround warning sound.
With this, I think a basic level of capability to guess battery remaining is ready for end-user testing. My hope is that from here, we just need to tweak the parameters inside
Battery.javaand maybe add a sharedPreference or two to adjust for board-to-board differences. We can't know that until we get feedback from multiple boards.Thanks for reviewing this pull request, let me know if we need to make any changes.