Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Karura integration #139

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Karura integration #139

wants to merge 11 commits into from

Conversation

borispovod
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Nov 22, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1489088559

  • 10 of 13 (76.92%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 44.663%
Changes Missing Coverage Covered Lines Changed/Added Lines %
primitives/src/currency.rs 10 13 76.92%
Totals Coverage Status
Change from base Build 1481469308: -1.0%
Covered Lines: 98
Relevant Lines: 172
💛 - Coveralls

@borispovod borispovod changed the title Karura support Karura integration Nov 22, 2021
@borispovod
Copy link
Member Author

Let's wait till #142 merged

boozook added a commit that referenced this pull request Nov 26, 2021
@boozook
add tests for CurrencyId (from #139)
da4aea0
boozook added a commit that referenced this pull request Nov 26, 2021
@AnthonyMikh @boozook
Unboilerplatify code for defining currencies (#142)
7b380fc 
* unboilerplatify code for defining currencies.
   This changes code to use a macro which enables easily adding new variants of currencies over time and excludes the possibility of mismatching variants in impls. Also new macro statically ensures that byte string identifiers ascipted to variants conforms their respective names.

* add tests for `CurrencyId` (from #139)

* add `TryFrom<&[u8]>` implementation for `CurrencyId` where ownership aren't required

Co-authored-by: Anthony Mikhailov <[email protected]>
Co-authored-by: Alexander Koz <[email protected]>
@borispovod
Copy link
Member Author

Don't merge till tests passed with Karura parachain.

cab404
cab404 reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@cab404 cab404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cab404 cab404 cab404 left review comments

@boozook boozook Awaiting requested review from boozook

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borispovod @coveralls @cab404