Make it build on Macos and fix how you template a container template #23
Conversation
| MallocExtension::instance()->ReleaseFreeMemory(); | ||
| #endif | ||
| malloc_stats(); |
There was a problem hiding this comment.
malloc_stats() doesn't depend on TCMALLOC and requires malloc.h: https://man7.org/linux/man-pages/man3/malloc_stats.3.html
We shouldn't replace malloc.h with stdlib.h. Instead, all the parts of the code that depend on malloc.h must be skipped on macOS:
#ifdef __GLIBC__
#include <malloc.h>
#endif
#ifdef __GLIBC__
malloc_stats();
#endif
There was a problem hiding this comment.
Thanks! That makes sense. I've tested it by building on both macos and ubuntu and running encoding/decoding. Do you think there is anything else I can test to make sure it actually works?
| @@ -289,7 +289,7 @@ namespace random { | |||
|
|
|||
| std::mt19937 *GetRandomGenerator(); | |||
|
|
|||
| template <typename T, template<class> typename C> | |||
| template <typename T, template <typename...> class C> | |||
There was a problem hiding this comment.
We must check that this doesn't break gcc on Linux, in return.
There was a problem hiding this comment.
could you pls give me some direction how we should test it besides building on a linux machine?
Successfully built and tested from the source code following the instructions in the README on
Also tested the build on a Ubuntu machine with a simple script which encodes and decodes random text.