Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci checks for deposits #42

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Conversation

vasyl-ivanchuk
Copy link
Collaborator

Modify CI workflow to spin up a dockerized node and run deposit examples.

@vasyl-ivanchuk vasyl-ivanchuk requested a review from popzxc as a code owner January 7, 2025 11:56
.gas_price(l1_gas_price)
.deploy()
.await?;
println!("L1 ERC20 token address: {}", erc20_token_address);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if stupid question, but shouldn't we also mint some tokens?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not needed, as this example token already mints tokens to the deployer. It’s the same token used in the Alloy example here, and as you can see, there is no minting in this example either.

@vasyl-ivanchuk vasyl-ivanchuk requested a review from popzxc January 7, 2025 12:14
@vasyl-ivanchuk vasyl-ivanchuk merged commit 439c5c0 into main Jan 7, 2025
4 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the add-ci-checks-for-deposits branch January 7, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants