Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ce 2.13 #256

Merged
merged 9 commits into from
Feb 23, 2022
Merged

Ce 2.13 #256

merged 9 commits into from
Feb 23, 2022

Conversation

deviantony
Copy link
Member

SvenDowideit and others added 9 commits February 14, 2022 08:31
…us allow cli-params _and_ --help (#228)

* feat(kingpin) use kingpin to parse ENV vars, and thus allow cli-params _and_ --help

Signed-off-by: Sven Dowideit <[email protected]>

* clean out unused env var names

Signed-off-by: Sven Dowideit <[email protected]>

* use the ENV text from the README

Signed-off-by: Sven Dowideit <[email protected]>

* HostManagementEnabled was hardcoded to true - I presume this was once a feature?

Signed-off-by: Sven Dowideit <[email protected]>

* do we need to store a copy of a bool we have access to?

Signed-off-by: Sven Dowideit <[email protected]>

* add the LogLevels to the flag options

Signed-off-by: Sven Dowideit <[email protected]>

* Don't try over-writing the existing /data/agent_edge_key - its 0444

Signed-off-by: Sven Dowideit <[email protected]>

* feat(edge): rollback key retrieval changes

* refactor(edge): remove comment

* feat(main): rollback changes to ip detection

* refactor(options): remove unused options

* refactor(options): remove comment

Co-authored-by: deviantony <[email protected]>
* feat(kingpin) use kingpin to parse ENV vars, and thus allow cli-params _and_ --help

Signed-off-by: Sven Dowideit <[email protected]>

* clean out unused env var names

Signed-off-by: Sven Dowideit <[email protected]>

* use the ENV text from the README

Signed-off-by: Sven Dowideit <[email protected]>

* HostManagementEnabled was hardcoded to true - I presume this was once a feature?

Signed-off-by: Sven Dowideit <[email protected]>

* do we need to store a copy of a bool we have access to?

Signed-off-by: Sven Dowideit <[email protected]>

* add the LogLevels to the flag options

Signed-off-by: Sven Dowideit <[email protected]>

* Don't try over-writing the existing /data/agent_edge_key - its 0444

Signed-off-by: Sven Dowideit <[email protected]>

* EdgeKey retreival code should be with the other EdgeKey code

Signed-off-by: Sven Dowideit <[email protected]>

* PROPOSAL: don't create an edgeManager if we're not in Edge mode

Signed-off-by: Sven Dowideit <[email protected]>

* add todo

Signed-off-by: Sven Dowideit <[email protected]>

* JUST git mv internal/edge/ to edge/

Signed-off-by: Sven Dowideit <[email protected]>

* git mv the scheduler code from filesystem/ to edge/scheduler/

Signed-off-by: Sven Dowideit <[email protected]>

* git mv edge/logs.go edge/scheduler/logs.go - jobID in logs == schedule.ID

Signed-off-by: Sven Dowideit <[email protected]>

* git mv edge/stack.go edge/stack/stack.go

Signed-off-by: Sven Dowideit <[email protected]>

* feat(edge): rollback key retrieval changes

* refactor(edge): remove comment

* feat(main): rollback changes to ip detection

* refactor(options): remove unused options

* refactor(options): remove comment

* refactor(http): update parameters

* refactor(edge): refactor of the edge package

* refactor(edge): refactor of the edge package

* refactor(edge): import refactor

* refactor(edge): refactor of the edge module

* refactor(edge): refactor imports

* refactor(http): do not store pointer to EdgeManager in Handler

* refactor(edge): refactor edge tunnel capability mgmt

* refactor(edge): rename parameter

* refactor(main): update Edge condition check

* refactor(http): review Edge mode server's handler enhancement

Co-authored-by: deviantony <[email protected]>
Copy link
Contributor

@sbusso sbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbusso sbusso merged commit b0ebf78 into develop Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants