Namespace creation

[saiyam1814]

#16 fixed

[funkypenguin]

Hey @saiyam1814! Thanks for the PR!

We actually had a considered internal discussion re whether to include a namespace resource in the helm chart, and decided not to, since helm v3 wants to store its secrets in the target namespace. If the target namespace doesn't exist, then helm can't store its secrets, and will error upon installation. Further, it seems to be generally accepted practice with helm v3 that the namespace should be created by the user, since namespaces are cluster-scoped resources, and it may be desirable to run helm with a service account with privileges limited to a single namespace. (I realize that's sort of redundant in the case of Portainer, since we assign our service account cluster-admin privileges anyway)

The conclusion we came to, is that for maximum compatibility between helm, CI/CD, and various implementation strategies, the user should create the namespace themselves, and then deploy into it using helm ;)

Cheers!
D

[saiyam1814]

Agree for helm 3 its expected that the user creates the namespace. But since its a file that can directly be used as mentioned in the docs as well, so thought of adding a namespace creation.

[saiyam1814]

I believe since these are stand-alone manifests to deploy portainer, so they should be complete.

[funkypenguin]

#50 addresses this, since --create-namespace is now supported in Helm v3.2+