Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore home menu order #2384

Merged
merged 5 commits into from
Nov 23, 2024

Conversation

u-foka
Copy link
Contributor

@u-foka u-foka commented Nov 23, 2024

  • Added a new field to external apps header (desired_menu_position) and bumped the header version to 3
  • Added the new field to all external apps (defaulted to -1: (no desire) except for remote that goes to index 4 on the home screen (also had some cosmetic changes in some of the main.ccp-s)
  • Update the python script that creates the ppma-s to account for the new field in the header
  • Applied the desired position to the apps when populating the screen
  • Also had some optimizations in btngrid to only update the items once, instead of each icon added, and potentially eliminated a copy (might have already been optimized out by the compiler)
  • Moved the missing ext apps notice on the home screen to index 2 to preserve the position of the rx and tx submenus

Currently only external apps have desired locations, we could add it also for the standalone ones in the future.

Current menu layout:

  • Built in apps (might be mixed with external apps that has desired position)
  • i2c module app
  • external apps (without a desired position)
  • standalone apps

Closes #2374

No need to alter the position of the ext app notice, as there is no back button on the home screen
@u-foka u-foka marked this pull request as ready for review November 23, 2024 16:17
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great job @u-foka !

@gullradriel
Copy link
Member

Currently only external apps have desired locations, we could add it also for the standalone ones in the future.

Now I want to have this too, maybe in another PR. Should I open an enhancement issue ? ^^

@gullradriel gullradriel merged commit 6927163 into portapack-mayhem:next Nov 23, 2024
3 checks passed
@u-foka u-foka deleted the restore_home_menu_order branch November 23, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to specify application appearance priority in the menus
3 participants