Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring CRDs management #6276

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Refactoring CRDs management #6276

wants to merge 2 commits into from

Conversation

nlamirault
Copy link
Collaborator

@nlamirault nlamirault commented Feb 4, 2025

Summary by CodeRabbit

  • Chores

    • Refined dependency management for custom resource definitions by adding updated entries and removing deprecated ones.
  • New Features

    • Introduced new configuration toggles to control specific CRD behaviors, enhancing flexibility and operational control.

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault added priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix status/in_progress This issue or PR is being worked on, and has someone assigned kind/feature Categorizes issue or PR as related to a new feature area/kubernetes Kubernetes lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Feb 4, 2025
@nlamirault nlamirault self-assigned this Feb 4, 2025
Copy link

coderabbitai bot commented Feb 4, 2025

Walkthrough

This pull request updates the CRD-related configuration in the Helm chart. In the Chart.yaml file, several CRD dependencies are added while others are removed, with the traefik-crds dependency also updated for its repository and version. In addition, the values.yaml file now includes a new section for traefik-crds with boolean configuration options, enhancing the structure and organization of the chart configurations.

Changes

File Path Change Summary
gitops/argocd/.../Chart.yaml Added: New dependency entries for CRDs such as mariadb-operator-crds, cloudnative-pg-crds, external-dns-crds, karpenter-crds, prometheus-operator-crds, and external-secrets-crds.
Modified: traefik-crds repository updated to oci://ghcr.io/traefik/helm with version bump from 1.0.0 to 1.2.0.
Removed: Redundant entries for prometheus-operator-crds, karpenter-crd, and mariadb-operator-crds.
gitops/argocd/.../values.yaml Added: New traefik-crds section containing boolean properties: traefik (true), gatewayAPI (false), hub (false), and deleteOnUninstall (false).

Poem

I'm a rabbit, hopping with delight,
Celebrating changes both crisp and bright.
CRDs have danced into the chart's grand hall,
While values sing a fresh, clear call.
With a twitch of my nose, I cheer this tune—
Code and carrots, in harmony, soon!
Hop on, dear changes, under a digital moon!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nlamirault
Copy link
Collaborator Author

@coderabbitai review

Copy link

coderabbitai bot commented Feb 4, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions github-actions bot added the size/m Size M label Feb 4, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
gitops/argocd/charts/crds/crds/values.yaml (1)

18-23: New 'traefik-crds' Configuration Section Introduced
A new section, traefik-crds, has been added with boolean properties for traefik, gatewayAPI, hub, and deleteOnUninstall. This section appears designed to complement the updated dependency in the Chart.yaml. Consider adding inline comments or documentation that briefly describes what each option controls to improve clarity for future maintainers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7eaf5cf and 1cc8a0b.

📒 Files selected for processing (2)
  • gitops/argocd/charts/crds/crds/Chart.yaml (1 hunks)
  • gitops/argocd/charts/crds/crds/values.yaml (1 hunks)
🔇 Additional comments (1)
gitops/argocd/charts/crds/crds/Chart.yaml (1)

43-45: Updated 'traefik-crds' Dependency Reference
The traefik-crds dependency now points to oci://ghcr.io/traefik/helm with a version update to 1.2.0 instead of the previous repository and version. This change aligns with the new configuration in the values file. Please verify that the new repository is fully compatible with your intended CRD management and that any breaking changes from the upstream chart have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Kubernetes kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix size/m Size M status/in_progress This issue or PR is being worked on, and has someone assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant