-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring CRDs management #6276
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Lamirault <[email protected]>
WalkthroughThis pull request updates the CRD-related configuration in the Helm chart. In the Changes
Poem
Tip 🌐 Web search-backed reviews and chat
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
gitops/argocd/charts/crds/crds/values.yaml (1)
18-23
: New 'traefik-crds' Configuration Section Introduced
A new section,traefik-crds
, has been added with boolean properties fortraefik
,gatewayAPI
,hub
, anddeleteOnUninstall
. This section appears designed to complement the updated dependency in the Chart.yaml. Consider adding inline comments or documentation that briefly describes what each option controls to improve clarity for future maintainers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
gitops/argocd/charts/crds/crds/Chart.yaml
(1 hunks)gitops/argocd/charts/crds/crds/values.yaml
(1 hunks)
🔇 Additional comments (1)
gitops/argocd/charts/crds/crds/Chart.yaml (1)
43-45
: Updated 'traefik-crds' Dependency Reference
Thetraefik-crds
dependency now points tooci://ghcr.io/traefik/helm
with a version update to1.2.0
instead of the previous repository and version. This change aligns with the new configuration in the values file. Please verify that the new repository is fully compatible with your intended CRD management and that any breaking changes from the upstream chart have been addressed.
Summary by CodeRabbit
Chores
New Features