Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

결제연동 리뉴얼 - V2 API Secret 수동 발급 문의 부분 제거 #375

Merged

Conversation

LimJiGyu
Copy link
Contributor

콘솔 결제연동 페이지가 리뉴얼되면서 V2 API Secret 을 수동으로 발급할 필요가 없어졌습니다.
따라서, V2 Tech Support 메일로 수동발급 요청해야 한다는 부분을 제거하고, 인증 API를 사용하는 최초 페이지인 수기결제 탭에 관련 문구를 추가하였습니다.

@LimJiGyu LimJiGyu self-assigned this Mar 25, 2024
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:38am

@@ -22,6 +22,8 @@ import Hint from "~/components/Hint.astro";

고객사 서버에서 아래와 같이 포트원 API를 호출합니다.

**PORTONE_API_SECRET**은 V2 전용 시크릿으로, 포트원 콘솔 내 결제연동 탭에서 발급받을 수 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 이거 링크 달아주시고.... 순서상으로 보면 인증결제 문서에 가장 먼저 나오는 것 같아서 여기 넣기 애매한 것 같긴 해요
https://developers.portone.io/docs/ko/ready/readme?v=v2#4-2-v2-api-secret-%EB%B0%9C%EA%B8%89%ED%95%98%EA%B8%B0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 인증결제 문서에 해당 링크 달아서 위치 바꿔보았습니다~

@LimJiGyu LimJiGyu force-pushed the feat/remove-v2-api-secret-manual branch from 384fe6e to ebfe345 Compare March 25, 2024 04:25
@LimJiGyu LimJiGyu changed the base branch from main to update-outdated-20240314 March 25, 2024 05:31
@LimJiGyu LimJiGyu force-pushed the feat/remove-v2-api-secret-manual branch from ebfe345 to 803f2bb Compare March 25, 2024 05:33
@LimJiGyu LimJiGyu force-pushed the feat/remove-v2-api-secret-manual branch from 803f2bb to 4be6a80 Compare March 25, 2024 05:51
@LimJiGyu LimJiGyu requested a review from XiNiHa March 25, 2024 05:55
@LimJiGyu
Copy link
Contributor Author

LimJiGyu commented Mar 25, 2024

요거 PR update-outdated-20240314 이랑 합쳐서 나가는게 좋을거 같아서, 이거 머지되고나면 베이스 PR 린트 깨진것들이랑 컨플릭 고쳐서 한 번에 메인으로 보내겠습니다 @XiNiHa @sso-ashley

@LimJiGyu LimJiGyu force-pushed the update-outdated-20240314 branch 2 times, most recently from b34fda4 to 543a53a Compare March 25, 2024 06:33
@LimJiGyu LimJiGyu force-pushed the feat/remove-v2-api-secret-manual branch from 4be6a80 to 477957b Compare March 25, 2024 06:35
@LimJiGyu
Copy link
Contributor Author

@XiNiHa @sso-ashley 베이스 PR #357 도 여기서 고쳐둔 파일(authpay.mdx) 제외하면 린트 모두 고쳐놔서, 한 번에 리뷰 가능합니다 ㅎㅎ

Copy link
Contributor

@sso-ashley sso-ashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants