Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 KPN 연동가이드 #400

Merged
merged 17 commits into from
Apr 12, 2024
Merged

V2 KPN 연동가이드 #400

merged 17 commits into from
Apr 12, 2024

Conversation

LimJiGyu
Copy link
Contributor

@LimJiGyu LimJiGyu commented Apr 4, 2024

V2 KPN이 신규 연동되면서 관련된 내용들을 연동가이드에 추가합니다.
작성한 항목들은 아래와 같습니다.

  • PG사 계약 관련 방법
  • 가상계좌 입금통보 URL & PG사 설정 가이드
  • 결제 요청, 빌링키 요청 페이지 내 PG사 코드 추가
  • V2 메인 페이지에 연동 가능한 PG사 목록 추가
  • KPN 메인 PG사 가이드

@LimJiGyu LimJiGyu self-assigned this Apr 4, 2024
Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 6:03am

@LimJiGyu LimJiGyu marked this pull request as ready for review April 9, 2024 04:15
@LimJiGyu LimJiGyu requested a review from ltnscp9028 April 9, 2024 05:16
@LimJiGyu
Copy link
Contributor Author

LimJiGyu commented Apr 9, 2024

@XiNiHa 드디어 모든 코멘트를 반영했습니다 !
대부분 간단한거라 딱히 얘기할건 없을거 같고, 코드블럭 부분이 의도하신 코드가 맞는지 체크 부탁드려요 ㅎㅎ

Copy link
Contributor

@XiNiHa XiNiHa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정해주신 부분 중에 일부만 반영된 것들이 있더라구요...! 제가 그냥 커밋해버리도록 하겠습니다 😂

@sso-ashley
Copy link
Contributor

@LimJiGyu KPN 콘솔에서 공식명칭 한국 결제 네트웍스 로 쓸 예정이므로 연동가이드에 전부 KPN -> 한국 결제 네트웍스로 변경해주세요.

@@ -68,6 +68,7 @@ description: 빌링키 발급 요청 파라미터를 확인할 수 있습니다.
> - `KCP_DIRECT`
> - `KAKAO`
> - `KSNET`
> - `KPN`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위에 V1 파라미터들 별도의 브랜치에 수정해놔서 반영 후 리베이스 필요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 포함해서 다 완료했습니다.

@LimJiGyu
Copy link
Contributor Author

LimJiGyu commented Apr 11, 2024

한국 결제 네트웍스 -> 한국결제네트웍스 변경

@sso-ashley 가 4/12 (금) 검수하여 머지할 예정

@sso-ashley sso-ashley merged commit 22a36f5 into main Apr 12, 2024
4 checks passed
@sso-ashley sso-ashley deleted the feat/kpn branch April 12, 2024 04:24
kms0219kms added a commit to allpgs/portone-restv2-client-nodejs that referenced this pull request Apr 16, 2024
XiNiHa added a commit that referenced this pull request Apr 17, 2024
Co-authored-by: y0on2q <[email protected]>
Co-authored-by: Cosmo Shin (신의하) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants