-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SystemVersion 동작 리팩토링 #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CirnoV
reviewed
Apr 24, 2024
CirnoV
reviewed
Apr 24, 2024
CirnoV
reviewed
Apr 25, 2024
const docCollection = defineCollection({ | ||
schema: z.object({ | ||
title: z.string(), | ||
description: z.string(), | ||
targetVersions: z.array(SystemVersion).optional(), | ||
versionVariants: z.record(SystemVersion, z.string()).optional(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 #30 하는김에 같이 해결해야겠네요.
AST Explorer에서 보니 remark-frontmatter 플러그인이 적용된 상태에서는 yaml 노드로 파싱되더라구요. 이러면 전에 만든 lint 플러그인만 수정해줘도 될 것 같아요.
단일 모듈 버전만 지원하는 문서 접속 시 URL의 버전을 덮어씌우는 동작 추가
CirnoV
approved these changes
Apr 25, 2024
CirnoV
approved these changes
Apr 25, 2024
sso-ashley
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SystemVersion의 동작을 리팩토링합니다.
?v=
가 붙지 않습니다.(예:
/docs/ko/v2-payment/v2?v=v1
접속 시에도/docs/ko/v2-payment/v2?v=v2
로 덮어씌워짐)Closes #346