Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

관리자콘솔 관련 내용 수정 #433

Merged
merged 23 commits into from
May 8, 2024
Merged

관리자콘솔 관련 내용 수정 #433

merged 23 commits into from
May 8, 2024

Conversation

sso-ashley
Copy link
Contributor

@sso-ashley sso-ashley commented Apr 26, 2024

빌링결제 오픈과 동시에 머지되어야 함

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:49am

@sso-ashley sso-ashley marked this pull request as ready for review May 2, 2024 07:35
@sso-ashley sso-ashley requested a review from XiNiHa as a code owner May 2, 2024 07:35
- **가상계좌** : 결제 요청 시 결제 수단을 가상계좌 (`pay_method : vbank`)로
지정하여 호출한 뒤 가상계좌로 진행된 거래 건만 표시됩니다.

- **휴대폰 소액결제** : 결제 요청 시 결제 수단을 휴대폰 소액결제 (`pay_method : phome`)로
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phone 오타

Comment on lines 163 to 178
- **컬쳐랜드** : 결제 요청 시 결제 수단을 컬쳐랜드 문화상품권
(`payMethod : giftCertificate`, `giftCertificate.giftCertificateType :CULTURELAND`)로 지정하여 호출한 뒤
컬쳐랜드 문화상품권으로 진행된 거래 건만 표시됩니다.

- **스마트문상** : 결제 요청 시 결제 수단을 스마트문상
(`payMethod : giftCertificate`, `giftCertificate.giftCertificateType : SMART_MUNSANG`)로 지정하여 호출한 뒤
스마트문상 ((구)게임문화상품권)으로 진행된 거래 건만 표시됩니다.

- **북앤라이프** : 결제 요청 시 결제 수단을 북앤라이프
(`payMethod : giftCertificate`, `giftCertificate.giftCertificateType : BOOKNLIFE`)로 지정하여 호출한 뒤
도서문화상품권으로 진행된 거래 건만 표시됩니다.

- **해피머니** : 결제 요청 시 결제 수단을 해피머니
(`payMethod : giftCertificate`, `giftCertificate.giftCertificateType : HAPPYMONEY`)로 지정하여 호출한 뒤
해피머니로 진행된 거래 건만 표시됩니다.
Copy link
Contributor

@highright96 highright96 May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

payMethod 전부 GIFT_CERTIFICATE로 변경하는게 맞을 듯 합니다

@XiNiHa XiNiHa force-pushed the feature/biilingPayments branch from 31305d9 to afa5df9 Compare May 2, 2024 08:08
Comment on lines 123 to 132
- **전체** : 모든 빌링 결제 상태의 거래를 조회합니다.

- **예약** : 예약 (status : Scheduled / Rescheduled) 상태이거나 예약 일정 변경
(status : ScheduleChanged) 거래 건만 표시됩니다.

- **성공** : 결제 대기 (status : Pending) 및 결제 성공 (status : Succeeded / RetrySucceeded) 상태인 거래 건만 표시됩니다.

- **실패** : 실패 (status : Failed / RetryFailed) 상태인 거래 건만 표시됩니다.

- **해지** : 해지 (status : Revoked) 상태인 거래 건만 표시됩니다.
Copy link
Contributor

@highright96 highright96 May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rescheduled, RetrySucceeded, RetryFailed 상세 상태(마지막 이벤트)라서 보여줄 필요가 없을 것 같은데 어떠신가요?

<VersionGate>
<Fragment slot="v1">
- 결제예약 API(Schedule API)를 이용한 결제 예약 건 중 정상적으로 예약 결제가 진행되어 결제 성공 상태인 거래 건입니다.
- 비 인증 결제(빌링키) API(Again API)를 이용한 결제 건 중 정상적으로 결제가 진행되어 결제 성공 상태인 겨래 건입니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

겨레 -> 거래

Copy link
Contributor

@highright96 highright96 May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

겨레로 쓴 오타가 몇 개 더 있습니다. 코멘트는 넘기겠습니다~!

src/content/docs/ko/console/guide/account.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/console/guide/billing-payments.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/console/guide/integration.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/console/guide/payments.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/console/guide/payments.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/console/guide/payments.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/console/guide/reg.mdx Outdated Show resolved Hide resolved
src/content/docs/ko/console/guide/reg.mdx Outdated Show resolved Hide resolved
sso-ashley and others added 16 commits May 8, 2024 15:13
@sso-ashley sso-ashley force-pushed the feature/biilingPayments branch from ca0d33e to 199db76 Compare May 8, 2024 06:13
@CirnoV CirnoV requested a review from XiNiHa May 8, 2024 06:58
Copy link
Contributor

@XiNiHa XiNiHa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내용 검수는 일단 스킵할게요

@XiNiHa XiNiHa merged commit e686844 into main May 8, 2024
3 checks passed
@XiNiHa XiNiHa deleted the feature/biilingPayments branch May 8, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants