Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb-4579: Added check to ignore sseTypePath secret file as it is optional #315

Merged
merged 1 commit into from
Oct 11, 2023
Merged

pb-4579: Added check to ignore sseTypePath secret file as it is optional #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/executor/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,12 @@ func parseS3Creds() (*Repository, error) {

sseType, err := os.ReadFile(sseTypePath)
if err != nil {
errMsg := fmt.Sprintf("failed reading data from file %s : %s", sseTypePath, err)
logrus.Errorf("%v", errMsg)
return nil, fmt.Errorf(errMsg)
// sseTypePath field in the secret is optional, So ignoring if the file does not exists.
if !os.IsNotExist(err) {
errMsg := fmt.Sprintf("failed reading data from file %s : %s", sseTypePath, err)
logrus.Errorf("%v", errMsg)
return nil, fmt.Errorf(errMsg)
}
siva-portworx marked this conversation as resolved.
Show resolved Hide resolved
}

disableSsl, err := os.ReadFile(disableSslPath)
Expand Down
Loading