-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pb-4969: Fixed issue with backuplocation CR variable, which was causing the nfs backup issue. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the nfs backup issue. - backuplocation CR variable scope was lost inside the if condtion. Because of this the nfs parameters are not passed to kopia job. - The kopia writes the snapshot file directly inside the job pod file system and files are lost once the pod is completed. - Since the nfs parameters are not passed, the nfs pvc was not getting mounted inside the nfs job pod.
siva-portworx
requested review from
adityadani,
lalat-das,
diptiranjanpx,
prashanthpx,
px-kesavan and
vsundarraj-px
November 21, 2023 18:06
OSS Scan Results:
Total issues: 326 |
License Evaluation Results:
Total License Issues: 19 |
lalat-das
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
prashanthpx
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes # pb-4969
Special notes for your reviewer:
Testing: