Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb-5019: Added logic to fetch the default encryption type for FBDA, if #325

Merged
merged 1 commit into from
Nov 30, 2023
Merged

pb-5019: Added logic to fetch the default encryption type for FBDA, if #325

merged 1 commit into from
Nov 30, 2023

Conversation

siva-portworx
Copy link
Contributor

What this PR does / why we need it:

    pb-5019: Added logic to fetch the default encryption type for FBDA, if
    it is not set in the kdmp-config cm.

            - frst case, if the exclude file list key is empty in the
              kdmp-config cm, we will try to set the default exclude file list for
              FBDA, if the storage class is FBDA.
            - second case, if the exclude file list key is not empty in the
              kdmp-cpnfig cm, if it did not had rule for FBDA storage class, we will
              try to set the degault execlude file list for the FBD, if the storage
              class is FBDA.

Which issue(s) this PR fixes (optional)
Closes # pb-5019

Special notes for your reviewer:
Testing:
Tested below two cases:

  1. Did not had any exlcude file list key parameter in the kdmp-config cm and took backup of FBDA vdbench namespace and restored it. It was successful and pods came up fine.
  2. Has a exclude list key parameter but for different storage class in the kdmp-config cm and took backup of FBDA vdbench namespace and restored it. It was successful and pods came up fine.

Note: Need to vendor it to stork repo.

@github-actions GitHub Actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']

Total License Issues: 19

prashanthpx
prashanthpx approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@prashanthpx prashanthpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/controllers/dataexport/reconcile.go Outdated Show resolved Hide resolved
pkg/controllers/dataexport/reconcile.go Show resolved Hide resolved
pb-5019: Added logic to fetch the default encryption type for FBDA, if
724ad49 
it is not set in the kdmp-config cm.

	- frst case, if the exclude file list key is empty in the
	  kdmp-config cm, we will try to set the default exclude file list for
	  FBDA, if the storage class is FBDA.
	- second case, if the exclude file list key is not empty in the
	  kdmp-cpnfig cm, if it did not had rule for FBDA storage class, we will
	  try to set the degault execlude file list for the FBD, if the storage
	  class is FBDA.
@github-actions GitHub Actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']

Total License Issues: 19

@github-actions GitHub Actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/k8sutils@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/version@#29f495ef07e2', 'github.com/hashicorp/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#29f495ef07e2', 'github.com/libopenstorage/stork/pkg/platform/rancher@#29f495ef07e2', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/[email protected]']

Total License Issues: 19

vsundarraj-px
vsundarraj-px approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@vsundarraj-px vsundarraj-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assumption made should be documented.

@siva-portworx siva-portworx merged commit e8a1e0c into master Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsundarraj-px vsundarraj-px vsundarraj-px approved these changes

@px-kesavan px-kesavan px-kesavan approved these changes

@prashanthpx prashanthpx prashanthpx approved these changes

@adityadani adityadani Awaiting requested review from adityadani

@lalat-das lalat-das Awaiting requested review from lalat-das

@vikasit12 vikasit12 Awaiting requested review from vikasit12

@aghodke1312 aghodke1312 Awaiting requested review from aghodke1312

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siva-portworx @prashanthpx @px-kesavan @vsundarraj-px