-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pb-6677: Add storage domain for azure cloud provider #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSS Scan Results:
Total issues: 191 |
License Evaluation Results:
Total License Issues: 19 |
OSS Scan Results:
Total issues: 191 |
License Evaluation Results:
Total License Issues: 20 |
OSS Scan Results:
Total issues: 191 |
License Evaluation Results:
Total License Issues: 20 |
shkumari-px
requested review from
prashanthpx,
vsundarraj-px,
vikasit12 and
lalat-das
April 25, 2024 13:50
siva-portworx
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
px-kesavan
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Based on the azure Env type, it adds the storage domain in the repoCreate and repoConnect Command for azure cloud Provider
Which issue(s) this PR fixes (optional)
Closes # PB-6677
Special notes for your reviewer:
Unit Testing
vendored these stork changes to px-backup
Passed the azure env type to backup location cr from px-backup and took a backup on that bl
Enabled generic backup
kopia tries to connect to the repo in case of AZURE_PUBLIC, this validates the storage Domain
In case of AZURE_CHINA, kopia tries to create the repo, validated storage domain from the repoCreateCommand
Repo Connect Command (Azure Public)
Repo Create Command (Azure China)
Repo Creation failed in case of Azure China since we don't have the credential
Azure-China Backup