pb-6681: Add support for PSA in kdmp job #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added check and collected psa info from the namespace - if psa enabled then extracted the uid and gid used by the POD. here the pod is choosen based on whichever PVC is used by that pod - applied those uid and GID to all relevant job pod spec - this is done only if the PSA mode enforced with "restricted" value - for baseline and privilege mode no restriction on UID/GID and default setting of SElinux and secomp is adopted in the POD spec Signed-off-by: Lalatendu Das <[email protected]>
|
OSS Scan Results:
Total issues: 191 |
|
License Evaluation Results:
Total License Issues: 20 |
lalat-das
requested review from
prashanthpx,
vsundarraj-px,
siva-portworx,
pallav-px and
vikasit12
px-kesavan
reviewed
May 7, 2024
| @@ -385,6 +402,15 @@ func jobFor( | |||
| }, | |||
| } | |||
|
|
|||
| if job.Spec.Template.Spec.SecurityContext != nil { | |||
There was a problem hiding this comment.
We don't require this check , as we are initializing the SecurityContext above . Similarly for all the operations
px-kesavan
reviewed
May 7, 2024
| } | ||
| if !psaIsEnforced { | ||
| errMsg := fmt.Sprintf("PSA is not enforced in namespace [%s], no need to enforce any uid/gid in job for backing up pvc [%s]", namespace, pvcName) | ||
| logrus.Debugf("%s: %v", fn, errMsg) |
There was a problem hiding this comment.
Here its a debug , but in the caller we are logging error if PSA is not enforced
px-kesavan
reviewed
May 7, 2024
|
|
||
| // get Pod from PVC details | ||
| func GetPodFromPVC(pvcName, namespace string) (*corev1.Pod, error) { | ||
| fn := "GetPodFromPVCName" |
There was a problem hiding this comment.
Nit, change it to same as function name
|
Created a new PR and addressed the review comment given by kesavan in that new PR. That PR is created since we need to vendor a different stork version from private to master. And a lot other changes to be addressed hence made a separate branch and a PR eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: this adds the PSA feature to px-backup
Which issue(s) this PR fixes (optional)
Closes # pb-6681
Special notes for your reviewer:
Currently Unit testing, this is a PR to get hold of the code review earlier.
Known Issue : restore path doesn't have a deployment to capture UID and GID, we will use the backupInfo artifacts in mongo to provide that. we should have captured it during backup time.