-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-6853: travis changes to push docker images for private branches #376
Conversation
OSS Scan Results:
Total issues: 191 |
License Evaluation Results:
Total License Issues: 20 |
@@ -13,7 +13,7 @@ script: | |||
elif [ "${TRAVIS_BRANCH}" == "master" ]; then | |||
export DOCKER_IMAGE_TAG=master-latest | |||
else | |||
export RELEASE_VER=`git rev-parse --short HEAD` | |||
export DOCKER_IMAGE_TAG=${TRAVIS_BRANCH} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do the same for px-backup as well @dbinnal-px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, Will check with @prashanthpx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking back, the reason they had git sha was a docker image build was always available for every commit we make and is consumable. When this changes to branch, then there are possibility that more than one people working on the same branch will have images overwritten. I think then lets keep the change as is before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing the PR
What this PR does / why we need it:
Travis changes to push the docker images for private branches with branch name as tag.
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: