-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pb-7598: Removed default addition of the RunAsGroup in the securityAc… #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siva-portworx
requested review from
lalat-das,
prashanthpx,
vikasit12,
pallav-px and
vsundarraj-px
July 18, 2024 10:40
OSS Scan Results:
Total issues: 142 |
License Evaluation Results:
Total License Issues: 17 |
t-nidhin
approved these changes
Jul 18, 2024
prashanthpx
approved these changes
Jul 18, 2024
@@ -281,7 +281,9 @@ func jobForBackupResource( | |||
// The Job is intended to backup resources to NFS backuplocation | |||
// and it doesn't need a specific JOB uid/gid since it will be sqaushed at NFS server | |||
// hence used a global hardcoded UID/GID. | |||
job, err = utils.AddSecurityContextToJob(job, utils.KdmpJobUid, utils.KdmpJobGid) | |||
// Not passing the groupId as we do not want to set the RunAsGroup field in the securityContext | |||
// This helps us in setting the primaryGroup ID to root for the user ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Earlier comment and new comment are missleading. We may have to ensure one of them is valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes # pb-7598
Special notes for your reviewer:
Testing:
Tested the backup/restore with OCP setup of application that had RDB volume with offload option, which was failing previous with permission denied error.