-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-7645: Add pause to cleanup of resources if env is set in kdmp-config configmap #390
Conversation
OSS Scan Results:
Total issues: 238 |
License Evaluation Results:
Total License Issues: 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic seems to be good, left a few nits
OSS Scan Results:
Total issues: 238 |
License Evaluation Results:
Total License Issues: 17 |
OSS Scan Results:
Total issues: 238 |
License Evaluation Results:
Total License Issues: 17 |
OSS Scan Results:
Total issues: 238 |
License Evaluation Results:
Total License Issues: 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5c59461
to
90f2f0c
Compare
OSS Scan Results:
Total issues: 142 |
License Evaluation Results:
Total License Issues: 17 |
OSS Scan Results:
Total issues: 142 |
License Evaluation Results:
Total License Issues: 17 |
…ig configmap Signed-off-by: Abhisheka <[email protected]>
OSS Scan Results:
Total issues: 142 |
License Evaluation Results:
Total License Issues: 17 |
…
What this PR does / why we need it:
This PR pauses the cleanup that happens after the job is completed for the specified time in the PAUSE_RESOURCE_CLEANUP key.This is helpful incase of debugging to persist the resources for time mentioned
Which issue(s) this PR fixes (optional)
Closes #PB-7645
Special notes for your reviewer:
Tested scenarios with value and without the key in the config map,working as expected:
After the review comments: