Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb-8713: Added excludeResourceType option handing in the nfsexecutor apis. #403

Merged
merged 2 commits into from
Nov 18, 2024
Merged

pb-8713: Added excludeResourceType option handing in the nfsexecutor apis. #403

merged 2 commits into from
Nov 18, 2024

Conversation

siva-portworx
Copy link
Contributor

What this PR does / why we need it:

pb-8713: Added excludeResourceType option handing in the nfsexecutor apis.

Which issue(s) this PR fixes (optional)
Closes # pb-8713

Special notes for your reviewer:
Testing:
Case1:
Exclude PersistenceVolumeClaim:

bash-4.4$ ./pxbackupctl create backup --orgID default --backup-location-name nfs --backup-location-uid 9c4a0495-7a42-4641-b959-0d9b126b94b3 --cluster self --cluster-uid 3942983a-fec4-429e-a453-d509f10ed098 --name nfs1 --exclude-resourcetypes "PersistentVolumeClaim" --namespaces mysql  -e "localhost:10002" --authtoken=$auth
Backup nfs1 created successfully
bash-4.4$
Screenshot 2024-11-16 at 8 37 08 PM

Case2:
Exclude Deployment:

bash-4.4$ ./pxbackupctl create backup --orgID default --backup-location-name nfs --backup-location-uid 9c4a0495-7a42-4641-b959-0d9b126b94b3 --cluster self --cluster-uid 3942983a-fec4-429e-a453-d509f10ed098 --name nfs2 --exclude-resourcetypes "Deployment" --namespaces mysql  -e "localhost:10002" --authtoken=$auth
Backup nfs2 created successfully
bash-4.4$
Screenshot 2024-11-16 at 8 39 32 PM

Case 2:
Include PVC alone:
Screenshot 2024-11-16 at 8 48 16 PM

@github-actions GitHub Actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#1b6d535ef497', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']

Total License Issues: 17

@github-actions GitHub Actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#1b6d535ef497', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']

Total License Issues: 17

1 similar comment
@github-actions GitHub Actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/hashicorp/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/resourcecollector@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/csi@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/aws@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/azure@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/gcp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/portworx@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/snapshotter@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/[email protected]', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#1b6d535ef497', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/utils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/k8sutils@#1b6d535ef497', 'github.com/libopenstorage/stork/pkg/version@#1b6d535ef497', 'github.com/hashicorp/[email protected]']

Total License Issues: 17

@siva-portworx siva-portworx merged commit 81def25 into 1.2.16 Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbinnal-px dbinnal-px dbinnal-px approved these changes

@vsundarraj-px vsundarraj-px vsundarraj-px approved these changes

@aks-px aks-px aks-px approved these changes

@prashanthpx prashanthpx prashanthpx approved these changes

@vikasit12 vikasit12 Awaiting requested review from vikasit12

@px-kesavan px-kesavan Awaiting requested review from px-kesavan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siva-portworx @prashanthpx @aks-px @vsundarraj-px @dbinnal-px