-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-8410 Incorporate the logic not delete the restore job pods when mount failure occurs within 5 mins #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt failure occurs within 5 mins Signed-off-by: vsundarraj-px <[email protected]>
License Evaluation Results:
Total License Issues: 17 |
vsundarraj-px
changed the title
Incorporate the logic not delete the restore job pods when mount failure occurs within 5 mins
PB-8410 Incorporate the logic not delete the restore job pods when mount failure occurs within 5 mins
Nov 18, 2024
vikasit12
approved these changes
Nov 18, 2024
siva-portworx
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unt failure occurs within 5 mins
What this PR does / why we need it:
This PR handles Job pod mount failures which are transient. Currently while checking for job status and if we find that mount pvc mount has failed, we immediately kill the jobpod and return error. We noticed that this pvc mount failure are transient errors and mount actually succeeds in next few seconds. Hence, this PR enables a timeout settings through KDMP configMap setting. When set, if mount failure should occur, will not fail immediately but wait till the timout set and if still the mount failure occurs then the job is terminated with error.
Which issue(s) this PR fixes (optional)
Closes #
PB-8410
Special notes for your reviewer:
Unit testing done
NFS Restore
NFS Backup
KDMP Backup
KDMP Restore
Since the issue is not easily reproducible, the unit testing is performed with a debug image by forcefully setting mountFailure
Testing for invalid characters, Tested with negative number, tested with alphanumeric values.