-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-9059: proto changes to identify backup created by parallel backup schedule #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkumari-px
requested review from
siva-portworx,
vsundarraj-px,
pallav-px,
vikasit12 and
px-kesavan
December 17, 2024 12:55
OSS Scan Results:
Total issues: 91 |
License Evaluation Results:
Total License Issues: 0 |
vsundarraj-px
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OSS Scan Results:
Total issues: 91 |
License Evaluation Results:
Total License Issues: 0 |
shkumari-px
added a commit
that referenced
this pull request
Dec 20, 2024
shkumari-px
added a commit
that referenced
this pull request
Dec 20, 2024
* PB-8605: Add parallel_backup flag to BackupScheduleCreateRequest,BackupScheduleUpdateRequest and BackupScheduleInfo * PB-9059: proto changes to identify backup created by parallel backup schedule (#271) --------- Co-authored-by: SantoshKumarGajawada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto changes to identify backup created by parallel backup schedule
What this PR does / why we need it: This pr help us identify if the backup object has been created by a parallel backup enabled scheduled
This allows duplication of such backups later, enabling the population of the parallel_backup field for new backups from the existing backup object
Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PB-9059
Special notes for your reviewer:
vendored the changes to px-backup - PB-9059
Added the code to add the parallel_backup flag to the backup objects created by scheduled backup
https://github.com/pure-px/px-backup/commit/9590704600a68d7efced0921f5762f4275e29588#diff-2d23af055b74a6eac8270f68119d2061ab784f531e32df5926822aa5f8732a4fR2256