Fetching RKE endpoint from the env #2617
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snigdha-px
requested review from
vpinisetti-px,
mkoppal-px,
ak-px,
sn-px and
kshithijiyer-px
vpinisetti-px
requested changes
Jun 25, 2024
Comment on lines
+100
to
+113
| var endpoint string | ||
| if clusterName == "destination-config" { | ||
| rkeToken = os.Getenv("DESTINATION_RKE_TOKEN") | ||
| if rkeToken == "" { | ||
| return fmt.Errorf("env variable DESTINATION_RKE_TOKEN should not be empty") | ||
| endpoint = os.Getenv("DESTINATION_RKE_URL") | ||
| log.Infof("Destination endpoint: %v", endpoint) | ||
| if rkeToken == "" || endpoint == "" { | ||
| return fmt.Errorf("env variable DESTINATION_RKE_TOKEN or DESTINATION_RKE_URL should not be empty") | ||
| } | ||
| } else if clusterName == "source-config" { | ||
| rkeToken = os.Getenv("SOURCE_RKE_TOKEN") | ||
| if rkeToken == "" { | ||
| return fmt.Errorf("env variable SOURCE_RKE_TOKEN should not be empty") | ||
| endpoint = os.Getenv("SOURCE_RKE_URL") | ||
| log.Infof("Source endpoint: %v", endpoint) | ||
| if rkeToken == "" || endpoint == "" { | ||
| return fmt.Errorf("env variable SOURCE_RKE_TOKEN or SOURCE_RKE_URL should not be empty") |
There was a problem hiding this comment.
@snigdha-px Do we really need the check here. I believe we can create only one Rancher cluster and add both source & destination clusters to same Rancher cluster. In that case we no need to export two env variables and no check required.
@sudas-px Need your inputs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
At present we were constructing the rke endpoint using master IP.
Modified the code to get the endpoint from env variable
Which issue(s) this PR fixes (optional)
Closes #https://purestorage.atlassian.net/browse/PB-7331
Special notes for your reviewer:
https://jenkins.pwx.dev.purestorage.com/job/Users/job/Snigdha/job/RKE-system-test-pipeline-my-branch/