Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled Pure cloudsnap and groupsnap tests #2680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −23
Open

Re-enabled Pure cloudsnap and groupsnap tests #2680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 21 additions & 23 deletions tests/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,14 +1439,13 @@ func ValidatePureSnapshotsSDK(ctx *scheduler.Context, errChan ...*chan error) {
}
snapshotVolNames = append(snapshotVolNames, snapshotVolName)
})
// Temporarily disabled: PWX-37628
// Step(fmt.Sprintf("get %s app's volume: %s then create cloudsnap", ctx.App.Key, vol), func() {
// err = Inst().V.ValidateCreateCloudsnap(vol, params)
// expect(err).NotTo(beNil(), "error expected but no error received while creating Pure cloudsnap")
// if err != nil {
// expect(err.Error()).To(contain(errPureCloudsnapNotSupported.Error()), "incorrect error received creating Pure cloudsnap")
// }
// })
Step(fmt.Sprintf("get %s app's volume: %s then create cloudsnap", ctx.App.Key, vol), func() {
err = Inst().V.ValidateCreateCloudsnap(vol, params)
expect(err).NotTo(beNil(), "error expected but no error received while creating Pure cloudsnap")
if err != nil {
expect(err.Error()).To(contain(errPureCloudsnapNotSupported.Error()), "incorrect error received creating Pure cloudsnap")
}
})
}

// PWX-37645: Disabled while fixing partition edge cases
Expand Down Expand Up @@ -1513,21 +1512,20 @@ func ValidatePureSnapshotsPXCTL(ctx *scheduler.Context, errChan ...*chan error)
}
SnapshotVolumes = append(SnapshotVolumes, snapshotVolName)
})
// Temporarily disabled: PWX-37628
// Step(fmt.Sprintf("get %s app's volume: %s then create cloudsnap using pxctl", ctx.App.Key, vol), func() {
// err = Inst().V.ValidateCreateCloudsnapUsingPxctl(vol)
// expect(err).NotTo(beNil(), "error expected but no error received while creating Pure cloudsnap")
// if err != nil {
// expect(err.Error()).To(contain(errPureCloudsnapNotSupported.Error()), "incorrect error received creating Pure cloudsnap")
// }
// })
// Step("validating groupsnap for using pxctl", func() {
// err = Inst().V.ValidateCreateGroupSnapshotUsingPxctl(vol)
// expect(err).NotTo(beNil(), "error expected but no error received while creating Pure groupsnap")
// if err != nil {
// expect(err.Error()).To(contain(errPureGroupsnapNotSupported.Error()), "incorrect error received creating Pure groupsnap")
// }
// })
Step(fmt.Sprintf("get %s app's volume: %s then create cloudsnap using pxctl", ctx.App.Key, vol), func() {
err = Inst().V.ValidateCreateCloudsnapUsingPxctl(vol)
expect(err).NotTo(beNil(), "error expected but no error received while creating Pure cloudsnap")
if err != nil {
expect(err.Error()).To(contain(errPureCloudsnapNotSupported.Error()), "incorrect error received creating Pure cloudsnap")
}
})
Step("validating groupsnap for using pxctl", func() {
err = Inst().V.ValidateCreateGroupSnapshotUsingPxctl()
expect(err).NotTo(beNil(), "error expected but no error received while creating Pure groupsnap")
if err != nil {
expect(err.Error()).To(contain(errPureGroupsnapNotSupported.Error()), "incorrect error received creating Pure groupsnap")
}
})
}
Step("Delete the cloudsnaps created ", func() {
for _, vol := range SnapshotVolumes {
Expand Down