-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AKS cloud support for asyncdr #2737
base: master
Are you sure you want to change the base?
Conversation
dd1b44b
to
cd02470
Compare
pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsInternalLBKey] = awsInternalLBValue | ||
pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsLBTypeKey] = awsLBTypeVal | ||
pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsNLBTargetTypeKey] = awsNLBTargetTypeVal | ||
pxStc.Spec.Metadata.Annotations[pxStcServiceKey][awsLBSubnetKey] = os.Getenv("LB_SUBNET_KEY") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we add a check to see if LB_SUBNET_KEY
is empty?
log.FailOnError(err, "failed to change PX service to LoadBalancer on source cluster") | ||
} | ||
if cloudName == "eks" { | ||
pxService, err := core.Instance().GetService("portworx-service", "kube-system") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it "kube-system" or portworx namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -95,6 +95,9 @@ RUN apk add --no-cache openssh sshpass | |||
# Install dependancy for OCP 4.14 CLI | |||
RUN apk --update add gcompat | |||
|
|||
#Install aws-cli | |||
RUN apk add aws-cli && aws --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this cli used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its needed for EKS cluster switch from torepedo. We need to access source and destination.
Without this we get below error -
failed to switch to context. RefreshNodeRegistry Error
pkg/asyncdr/asyncdr.go
Outdated
log.Infof("Storage driver name: %v", storageDriverName) | ||
|
||
if storageDriverName == storkdriver.PortworxDriverName { | ||
stc, err := operator.Instance().ListStorageClusters(pxNamespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inst().V.GetDriver() will give you the STC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are still using operator.Instance()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this, just updated please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems your changes are missing. please check
pkg/asyncdr/asyncdr.go
Outdated
log.Infof("Storage driver name: %v", storageDriverName) | ||
|
||
if storageDriverName == storkdriver.PortworxDriverName { | ||
stc, err := operator.Instance().ListStorageClusters(pxNamespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are still using operator.Instance()
I added changes, Thanks! |
PTX-25618 - AKS cloud support for asyncdr
What this PR does / why we need it:
We can run asyncdr on cloud
Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PTX-25618
Special notes for your reviewer:
Passed Job -
https://jenkins.pwx.dev.purestorage.com/job/Users/job/Geet/job/stork-systemtest-aks/8/