Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ReferenceGenome as an option for Capture_Type #101

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Mar 18, 2025

As proposed in #66.

A special Date_Type is imho not necessary. Reference genomes conceptually exist outside of space and time. And multiple other .janno columns also don't apply for them. All of these can equally be set to n/a.

@nevrome nevrome requested a review from stschiff March 18, 2025 15:18
@stschiff
Copy link
Member

OK, but there should be some way to indicate that a "sample" is actually a reference genome. If not in Date_Type, then where do we indicate that?

Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, after Discussion on March 19.

@nevrome
Copy link
Member Author

nevrome commented Mar 27, 2025

If I remember our discussion correctly, then the argument against a special Date_Type value for reference genomes was that we would also need special values for various other columns. Dating is just one aspect affected.

For the time being I think it's fine to set everything to n/a that does not apply for reference genomes. Maybe eventually a field for the overarching Sample_Type would be useful.

@nevrome
Copy link
Member Author

nevrome commented Mar 27, 2025

Probably it's not sensible to merge this change to Capture_Type as long as we have no alternative.

What do you think about a Sample_Type column, Stephan? The difficulty is probably to come up with meaningful categories. Maybe just three simple classes?

  • AncientDNA
  • ModernDNA
  • ReferenceGenome

Each of these subsume various source materials and data generation techniques. We could inform such a column from the Date_Type column, but we would not have to rely on it any longer for this major distinction.

@stschiff
Copy link
Member

I happen to be convinced that it's OK to drop this. You correctly pointed out that it's easiest to just exclude those packages with reference genomes and that's that. So I think it's OK to just go ahead with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants