reconnect open data explorer editors on reload #5475
Merged
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcphers
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Code LGTM. I would recommend some polish around the UX, though; the data explorer tabs don't stay as you left them, but instead come in at the end, and they also always become the active tab even if you had something else active before reloading.
I think that some changes in the data explorer service itself (to mark these tabs as custom editors that can be restored?) are needed for a better UX. This is better than nothing, though, and it's nice that the state of the tab is restored too! (filters, sorts, etc.)
|
Great points! I have opened #5489 to capture the suggested UX improvements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3172
QA Notes
Open data explorer tabs should be restored for both Python and R sessions when Positron is reloaded. The tabs should appear once the runtime(s) have started.
See #5462 for notes on what "reloaded" means across the different Positron builds.
I've tested this in dev builds on Mac for Desktop and Server Web in Chrome.