Minimal notebook UI flag for vscode notebooks #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook UI based on its presence.
nstrayer
force-pushed
the
minimal-notebook-ui-flag
branch
from
0975a4c
to
c179ac7
Compare
Comment on lines
+76
to
+77
| // Old version | ||
| // const options = new NotebookOptions(mainWindow, false, undefined, instantiationService.get(IConfigurationService), instantiationService.get(INotebookExecutionStateService), instantiationService.get(ICodeEditorService)); |
There was a problem hiding this comment.
Can this commented out code be removed?
| /** | ||
| * Register a callback that will be invoked when the minimal UI mode changes. | ||
| * @param opts.callback The callback to invoke. | ||
| * @param opts.runWhenFirstSet Whether to run the callback when listener is first set. |
There was a problem hiding this comment.
Oh, this is interesting. In what scenarios would we not want to run the callback immediately after setting the listener?
|
Not sure if the following is a regression from this change but I noticed that the default notebook layout has some issues:
Screen.Recording.2024-11-18.at.5.11.36.PM.movScreen.Recording.2024-11-18.at.5.21.01.PM.movI did also try to turn the feature flag on but couldn't get the minimal ui to show. It may be user error though. I turned the feature on and then created a new jupyter project and opened it in the current window. Not sure what I did wrong there 😢 All that being said, I really love the minimal ui based off the video/screenshots in the PR description! |
…the cell after padding has been added to the bottom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new mode enabled by the feature flag
notebook.usePositronMinimalNotebookUIThe flag defaults to off.
Static changes
There are a few static visual changes:
Animation changes
Perhaps more important are the changes to the experience of navigating and running cells in the notebook.
Previously when you would run a cell the following animations would activate
Minimal mode removes the cell-level spinner and the bouncing progress bar to keep things a bit less hectic.
Running a cell with defaults
lots-of-animation.mov
Running cells with minimal mode
Screen.Recording.2024-11-15.at.12.43.31.PM.mov
QA Notes
This PR is almost entirely implemented via css, so there shouldn't be too many hiccups in terms of things changing. Since it's purely UI-based I held off on adding a smoke-test as that felt a bit overboard for this type of change.
Basically, after changing the feature flag, you should be able to open up any notebook you could open before and have things look a bit more... calm.