Make it so notebooks actually display the file name in their editor tab #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeM
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2628.
Previously we just displayed the helpful name 'Positron Notebook' for every positron notebook 2.0 tab open. This updates this to just display the file name.
QA Notes
Steps:
positron.notebooks.usePositronNotebooksExperimentalflagNew notebooks should also work and just show
untitled-*.ipynb(Although they still wont actually function until #4089 is fixed)There's a chance that the code doesn't handle some weird file name edge cases but I couldn't find any.