Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a tight bounding box when plotting at the intrinsic size #5437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Nov 21, 2024

Addresses #5068. This brings our matplotlib configuration closer to Jupyter Notebooks when using the intrinsic sizing policy which is probably more familiar to users.

Since the produced image pixel size is no longer guaranteed, I also changed the save plot modal to display the size in intrinsic units instead of pixels.

Known Issues

If you plot totally outside of the default bounding box, it's missed by our current plot change detection and an "update" is not sent to the frontend. I was unable to find a fix in a reasonable amount of fiddling.

It's a bit of a hack but you can manually request an update with fig.canvas.manager.update(). Maybe a better workaround would be to add a refresh button to the plots action bar?

QA Notes

Running the following code in a single execution should include the title in the plot (you can't run it line-by-line because of the known issue above).

fig, ax = plt.subplots()
fig.text(x=0.5, y=1, s='title')
plt.show()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant